lkml.org 
[lkml]   [2017]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 25/31] nds32: defconfig
2017-11-09 18:20 GMT+08:00 Arnd Bergmann <arnd@arndb.de>:
> On Thu, Nov 9, 2017 at 9:00 AM, Greentime Hu <green.hu@gmail.com> wrote:
>> 2017-11-08 18:03 GMT+08:00 Arnd Bergmann <arnd@arndb.de>:
>>> On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu <green.hu@gmail.com> wrote:
>>>> From: Greentime Hu <greentime@andestech.com>
>>>>
>>>> Signed-off-by: Vincent Chen <vincentc@andestech.com>
>>>> Signed-off-by: Greentime Hu <greentime@andestech.com>
>>>> ---
>>>> arch/nds32/configs/ae3xx_defconfig | 110 +++++++++++++++++++++++++++++++++++
>>>> arch/nds32/configs/ag101p_defconfig | 109 ++++++++++++++++++++++++++++++++++
>>>
>>> Are those two incompatible? I would recommend starting without board
>>> specific defconfig
>>> files, it just gets messy once you get more than a few machines you
>>> want to support.
>>
>> Thanks.
>> These 2 are incompatible.
>> They use different drivers. I may still keep these 2 defconfigs.
>
> Using different drivers doesn't make machines incompatible. For instance, the
> x86 desktop machine has drivers for all kinds of devices, but it uses
> one configuration
> that works on basically any x86 machine.
>
> Similarly, we only have one defconfig file on arm64, and it works across very
> diverse machines (phone, home routers, large servers, etc.).
>
> All drivers should be written in a way to allow being built into the
> kernel without
> doing any harm when you don't have the respective hardware.

Thanks.
Make sense.
I will keep only one defconfig in the next version patch.

>>>> +CONFIG_FB=y
>>>> +# CONFIG_VGA_CONSOLE is not set
>>>> +CONFIG_FRAMEBUFFER_CONSOLE=y
>>>
>>> You have a framebuffer console here, but no framebuffer driver?
>>
>> Thanks.
>> I shall enable it when I push our framebuffer in the next time.
>> I will disable it in the next version patch.
>
> The fbdev subsystem is no longer recommended for new drivers, they
> should be written on top of the DRM framework. You can use
> CONFIG_DRM_FBDEV_EMULATION to get the framebuffer
> console on top of that, but then you don't need to enable CONFIG_FB.
>
> Please have a look at drivers/gpu/drm/tinydrm/ to see if you can either
> use that directly, or take it as a skeleton for your own driver.
>

Thanks.
We will check how to use CONFIG_DRM_FBDEV_EMULATION to get framebuffer.

\
 
 \ /
  Last update: 2017-11-10 09:17    [W:0.128 / U:2.756 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site