lkml.org 
[lkml]   [2017]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] dynamic_debug: fix optional/omitted ending line number to be LARGE instead of 0
From
Date
On 11/09/2017 04:52 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> line-range is supposed to treat "1-" as "1-endoffile", so
> handle the special case by setting last_lineno to UINT_MAX.
>
> Fixes this error:
>
> dynamic_debug:ddebug_parse_query: last-line:0 < 1st-line:1
> dynamic_debug:ddebug_exec_query: query parse failed
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jason Baron <jbaron@akamai.com>
> ---
> lib/dynamic_debug.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> --- lnx-414-rc8.orig/lib/dynamic_debug.c
> +++ lnx-414-rc8/lib/dynamic_debug.c
> @@ -360,6 +360,10 @@ static int ddebug_parse_query(char *word
> if (parse_lineno(last, &query->last_lineno) < 0)
> return -EINVAL;
>
> + /* special case for last lineno not specified */
> + if (query->last_lineno == 0)
> + query->last_lineno = UINT_MAX;
> +
> if (query->last_lineno < query->first_lineno) {
> pr_err("last-line:%d < 1st-line:%d\n",
> query->last_lineno,
>

Acked-by: Jason Baron <jbaron@akamai.com>

\
 
 \ /
  Last update: 2017-11-10 22:44    [W:0.033 / U:1.696 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site