lkml.org 
[lkml]   [2017]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] IB/qib: remove redundant setting of any in for-loop
Date
> > On Fri, 2017-10-20 at 09:21 +0200, Colin King wrote:
> > > From: Colin Ian King <colin.king@canonical.com>
> > >
> > > The variable all is being set but is never read after this
> > > hence it can be removed from the for loop initialization.
> > > Cleans up clang warning:
> >
> > any is really used as bool and is initialized at function
> > entry. The earlier loop also reinitializes any unnecessarily.
>
> Denny, can you weigh in on what you want in this thread? Thanks.
>

I am ok with both Colin's and Joe's patch.

Joe's patch would require additional testing vs. the trivial warning fix.

Then there is a "guideline" to keep fixes separate from clean up...

Doug, do you want a tested patch from me?

Mike

\
 
 \ /
  Last update: 2017-11-10 20:07    [W:0.068 / U:6.560 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site