lkml.org 
[lkml]   [2017]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 12/31] nds32: Device specific operations
    2017-11-09 15:04 GMT+08:00 Greentime Hu <green.hu@gmail.com>:
    > 2017-11-08 17:04 GMT+08:00 Arnd Bergmann <arnd@arndb.de>:
    >> On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu <green.hu@gmail.com> wrote:
    >>
    >>> +
    >>> +#define ioremap(cookie,size) __ioremap(cookie,size,0,1)
    >>> +#define ioremap_nocache(cookie,size) __ioremap(cookie,size,0,1)
    >>> +#define iounmap(cookie) __iounmap(cookie)
    >>
    >>> +#include <asm-generic/io.h>
    >>
    >> asm-generic/io.h now provides an ioremap_nocache() helper along with
    >> ioremap_uc/ioremap_wc/ioremap_wt, so I think you can remove the
    >> ioremap_nocache definition here. You might also be able to remove
    >> __ioremap and __iounmap, and only provide ioremap/iounmap, plus
    >> the identity macro 'define ioremap ioremap'
    >
    > Thanks. I will try to use generic ioremap_nocache() helper in the next
    > version patch.

    I think I can't remove ioremap_nocache definition because it is defined
    in asm-generic/io.h with !CONFIG_MMU.

    \
     
     \ /
      Last update: 2017-11-10 17:08    [W:3.449 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site