lkml.org 
[lkml]   [2017]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/4] kernelshark: Adding gui_event_handlers for View and Graph
On Fri, 10 Nov 2017 14:29:14 +0200
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:


> +void trace_graph_register_gui_handler(struct graph_info *info,
> + struct gui_event_handler *handler) {
> + handler->next = info->event_handlers;
> + info->event_handlers = handler;
> +}
> +


>
> +void trace_view_store_register_gui_handler(TraceViewStore *store, struct gui_event_handler *handler)
> +{
> + handler->next = store->event_handlers;
> + store->event_handlers = handler;
> +}
> +


Hmm, and in the last patch we have:

+ trace_view_store_register_gui_handler(ks_store, switch_handler);
+ trace_view_store_register_gui_handler(ks_store, wakeup_handler);
+
+ trace_graph_register_gui_handler(ks_info->ginfo, switch_handler);
+ trace_graph_register_gui_handler(ks_info->ginfo, wakeup_handler);

I think I see an issue here. ;-)

(Hint, what's the state of switch_handler->next and
wakeup_handler->next, when this is done?)

-- Steve

\
 
 \ /
  Last update: 2017-11-10 16:30    [W:0.058 / U:46.344 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site