lkml.org 
[lkml]   [2017]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/30] x86, kaiser: unmap kernel from userspace page tables (core patch)

* Dave Hansen <dave.hansen@linux.intel.com> wrote:

> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> These patches are based on work from a team at Graz University of
> Technology: https://github.com/IAIK/KAISER . This work would not have
> been possible without their work as a starting point.

> Note: The original KAISER authors signed-off on their patch. Some of
> their code has been broken out into other patches in this series, but
> their SoB was only retained here.
>
> Signed-off-by: Richard Fellner <richard.fellner@student.tugraz.at>
> Signed-off-by: Moritz Lipp <moritz.lipp@iaik.tugraz.at>
> Signed-off-by: Daniel Gruss <daniel.gruss@iaik.tugraz.at>
> Signed-off-by: Michael Schwarz <michael.schwarz@iaik.tugraz.at>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>

That's not how SOB chains should be used normally - nor does the current code have
much resemblance to the original code.

So you credit them in the file:

> --- /dev/null 2017-11-06 07:51:38.702108459 -0800
> +++ b/arch/x86/mm/kaiser.c 2017-11-08 10:45:29.893681394 -0800
> @@ -0,0 +1,412 @@
> +/*
> + * Copyright(c) 2017 Intel Corporation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of version 2 of the GNU General Public License as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * General Public License for more details.
> + *
> + * Based on work published here: https://github.com/IAIK/KAISER
> + * Modified by Dave Hansen <dave.hansen@intel.com to actually work.

You could credit the original authors via something like:

/*
* The original KAISER patch, on which this code is based in part, was
* written by and signed off by for the Linux kernel by:
*
* Signed-off-by: Richard Fellner <richard.fellner@student.tugraz.at>
* Signed-off-by: Moritz Lipp <moritz.lipp@iaik.tugraz.at>
* Signed-off-by: Daniel Gruss <daniel.gruss@iaik.tugraz.at>
* Signed-off-by: Michael Schwarz <michael.schwarz@iaik.tugraz.at>
*
* At:
*
* https://github.com/IAIK/KAISER
*/

Or something like that - but the original SOBs should not be carried over as-is
into the commit log entry.

Thanks,

Ingo

\
 
 \ /
  Last update: 2017-11-10 13:58    [W:0.233 / U:3.992 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site