lkml.org 
[lkml]   [2017]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] USB :core :Prevent USB devices to autosuspend while setting interface
Date

Hi,

Abhijeet@vger.kernel.org, Kumar@vger.kernel.org writes:

these emails don't exist. Fix your email client.

> From: abhijeet kumar <abhijeet.kumar@intel.com>

capitalize names

> Runtime resume USB device in order to ensure that PM framework
> knows that the we might be using the device in a short time and doesn't
> autosuspend the device while we updating it's interface.

this doesn't tell me about any problem. What, exactly, are you trying to
fix?

> Signed-off-by: abhijeet kumar <abhijeet.kumar@intel.com>

capitalize names

> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index 371a07d874a3..658603ed779e 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
> @@ -1305,6 +1305,9 @@ int usb_set_interface(struct usb_device *dev, int interface, int alternate)
> if (iface->unregistering)
> return -ENODEV;
>
> + /*Letting runtime PM now that we wish to use the device in a short time
> + *pm_runtime_get(&iface->dev);
> + */

why is it so that adding commented out code help? Did you *really* test
this at all?

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-11-10 13:55    [W:0.037 / U:7.124 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site