lkml.org 
[lkml]   [2017]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v9 44/51] selftest/vm: powerpc implementation for generic abstraction
Hi Ram,

On Thu, Nov 09, 2017 at 03:37:46PM -0800, Ram Pai wrote:
> On Thu, Nov 09, 2017 at 04:47:15PM -0200, Breno Leitao wrote:
> > On Mon, Nov 06, 2017 at 12:57:36AM -0800, Ram Pai wrote:
> > > @@ -206,12 +209,14 @@ void signal_handler(int signum, siginfo_t *si, void *vucontext)
> > >
> > > trapno = uctxt->uc_mcontext.gregs[REG_TRAPNO];
> > > ip = uctxt->uc_mcontext.gregs[REG_IP_IDX];
> > > - fpregset = uctxt->uc_mcontext.fpregs;
> > > - fpregs = (void *)fpregset;
> >
> > Since you removed all references for fpregset now, you probably want to
> > remove the declaration of the variable above.
>
> fpregs is still needed.

Right, fpregs is still needed, but not fpregset. Every reference for this
variable was removed with your patch.

Grepping this variable identifier on a tree with your patches, I see:

$ grep fpregset protection_keys.c
fpregset_t fpregset;

\
 
 \ /
  Last update: 2017-11-10 12:37    [W:0.094 / U:3.328 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site