lkml.org 
[lkml]   [2017]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] lib: test module for find_*_bit() functions
On 11/10/17, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Thu, 9 Nov 2017 17:07:14 +0300 Yury Norov <ynorov@caviumnetworks.com>
> wrote:
>
>> find_bit functions are widely used in the kernel, including hot paths.
>> This module tests performance of that functions in 2 typical scenarios:
>> randomly filled bitmap with relatively equal distribution of set and
>> cleared bits, and sparse bitmap which has 1 set bit for 500 cleared bits.
>>
>> ...
>>
>> +config TEST_FIND_BIT
>
> Well. It doesn't actually "test" the code. It measures its performance ;)

Yes!

Yyra, you can grab CONFIG_BENCHMARK_* namespace :-)


Another thing:

> +
> + return 0;
> +}
> +module_init(find_bit_test);
> +
> +static void __exit test_find_bit_cleanup(void)
> +{
> +}
> +module_exit(test_find_bit_cleanup);

module exit hook is entirely unnecessary as you can return -E from init hook.
See lib/test-kstrtox.c

\
 
 \ /
  Last update: 2017-11-10 11:46    [W:0.062 / U:2.800 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site