lkml.org 
[lkml]   [2017]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mailbox: add support for doorbell/signal mode controllers
On Wed 01 Nov 11:15 PDT 2017, Sudeep Holla wrote:
>
> 80 writel_relaxed(msg->cmd, mb->mbox_base +
> MAILBOX_A2B_CMD(chans->idx));
> 81 writel_relaxed(msg->rx_size, mb->mbox_base +
>
> 82 MAILBOX_A2B_DAT(chans->idx));
>
> 83

This is just terrible, using the void *mssg to pass a struct which is
interpreted by the controller removes any form of abstraction provided
by the framework.

In my view the void *mssg should point to the data to be written in the
mailbox register, and hence might be of different size - but only of
native type.

Regards,
Bjorn

\
 
 \ /
  Last update: 2017-11-01 23:18    [W:0.076 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site