lkml.org 
[lkml]   [2017]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 114/139] [media] ir-core: fix gcc-7 warning on bool arithmetic
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    commit bd7e31bbade02bc1e92aa00d5cf2cee2da66838a upstream.

    gcc-7 suggests that an expression using a bitwise not and a bitmask
    on a 'bool' variable is better written using boolean logic:

    drivers/media/rc/imon.c: In function 'imon_incoming_scancode':
    drivers/media/rc/imon.c:1725:22: error: '~' on a boolean expression [-Werror=bool-operation]
    ictx->pad_mouse = ~(ictx->pad_mouse) & 0x1;
    ^
    drivers/media/rc/imon.c:1725:22: note: did you mean to use logical not?

    I agree.

    Fixes: 21677cfc562a ("V4L/DVB: ir-core: add imon driver")

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    drivers/media/rc/imon.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c
    index 72e3fa6..257bb7a 100644
    --- a/drivers/media/rc/imon.c
    +++ b/drivers/media/rc/imon.c
    @@ -1530,7 +1530,7 @@ static void imon_incoming_packet(struct imon_context *ictx,
    if (kc == KEY_KEYBOARD && !ictx->release_code) {
    ictx->last_keycode = kc;
    if (!nomouse) {
    - ictx->pad_mouse = ~(ictx->pad_mouse) & 0x1;
    + ictx->pad_mouse = !ictx->pad_mouse;
    dev_dbg(dev, "toggling to %s mode\n",
    ictx->pad_mouse ? "mouse" : "keyboard");
    spin_unlock_irqrestore(&ictx->kc_lock, flags);
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-11-01 22:38    [W:2.659 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site