Messages in this thread Patch in this message | | | Subject | Re: [PATCH] scripts: warn about invalid MAINTAINERS patterns | From | Joe Perches <> | Date | Wed, 01 Nov 2017 09:50:05 -0700 |
| |
(add mercurial-devel and xen-devel to cc's)
On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote: > Add "--pattern-checks" option to get_maintainer.pl to warn about invalid > "F" and "X" patterns found in MAINTAINERS file(s).
Hey again Tom.
About mercurial/hg.
While as far as I know there hasn't been a mercurial tree for the linux kernel sources in many years, I believe the mercurial command to list files should be different.
> my %VCS_cmds_hg = ( > @@ -167,6 +169,7 @@ my %VCS_cmds_hg = ( > "subject_pattern" => "^HgSubject: (.*)", > "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$", > "file_exists_cmd" => "hg files \$file", > + "list_files_cmd" => "hg files \$file",
I think this should be
"list_files_cmd" => "hg manifest -R \$file",
It seems to work on a XEN test branch but does anyone really care about hg support in get_maintainers?
btw: to the XEN maintainers
The XEN mercurial branch for MAINTAINERS has a few odd entries and a few missing file patterns
I think the XEN MAINTAINERS file should be updated to:
--- diff -r c60f04b73240 MAINTAINERS --- a/MAINTAINERS Mon Oct 16 15:24:44 2017 +0100 +++ b/MAINTAINERS Wed Nov 01 09:39:34 2017 -0700 @@ -246,7 +246,8 @@ KCONFIG M: Doug Goldstein <cardoe@cardoe.com> S: Supported -F: docs/misc/kconfig{,-language}.txt +F: docs/misc/kconfig.txt +F: docs/misc/kconfig-language.txt F: xen/tools/kconfig/ KDD DEBUGGER @@ -257,8 +258,8 @@ KEXEC M: Andrew Cooper <andrew.cooper3@citrix.com> S: Supported -F: xen/common/{kexec,kimage}.c -F: xen/include/{kexec,kimage}.h +F: xen/common/kexec.[ch] +F: xen/common/kimage.[ch] F: xen/arch/x86/machine_kexec.c F: xen/arch/x86/x86_64/kexec_reloc.S --- After the patch above is applied, --self-test shows:
$ ~/linux/next/scripts/get_maintainer.pl --self-test ./MAINTAINERS:403: warning: no matches F: drivers/xen/usb*/ ./MAINTAINERS:415: warning: no matches F: xen/arch/x88/hvm/vm_event.c ./MAINTAINERS:429: warning: no matches F: extras/mini-os/tpm* ./MAINTAINERS:430: warning: no matches F: extras/mini-os/include/tpm*
| |