Messages in this thread | | | Date | Wed, 1 Nov 2017 13:35:02 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 07/18] x86/asm/64: Merge the fast and slow SYSRET paths |
| |
On Wed, Nov 01, 2017 at 04:29:21AM -0700, Andy Lutomirski wrote: > I'm inclined to leave it. I first wrote it without the long name and > then I had to re-read the code to make sure I got the register state > right. The long name serves as documentation that we need rcx and r11 > to have special contents. There's only one place that jumps there and > it's in the same function.
Frankly, I'd prefer a sane label name and a good comment over it instead of insanely long label name which is not as explanatory as a normal english sentence or two.
-- Regards/Gruss, Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --
| |