lkml.org 
[lkml]   [2017]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 189/192] sched: fix confusing PFA_NO_NEW_PRIVS constant
    3.16.49-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Zefan Li <lizefan@huawei.com>

    commit a2b86f772227bcaf962c8b134f8d187046ac5f0e upstream.

    Commit 1d4457f99928 ("sched: move no_new_privs into new atomic flags")
    defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing
    because it is used as bit number. Redefine it as decimal bit number.

    Note this changes the bit position of PFA_NOW_NEW_PRIVS from 1 to 0.

    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Miao Xie <miaox@cn.fujitsu.com>
    Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
    Acked-by: Kees Cook <keescook@chromium.org>
    [ lizf: slightly modified subject and changelog ]
    Signed-off-by: Zefan Li <lizefan@huawei.com>
    Signed-off-by: Tejun Heo <tj@kernel.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    include/linux/sched.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/include/linux/sched.h
    +++ b/include/linux/sched.h
    @@ -1979,7 +1979,7 @@ static inline void memalloc_noio_restore
    }

    /* Per-process atomic flags. */
    -#define PFA_NO_NEW_PRIVS 0x00000001 /* May not gain new privileges. */
    +#define PFA_NO_NEW_PRIVS 0 /* May not gain new privileges. */

    static inline bool task_no_new_privs(struct task_struct *p)
    {
    \
     
     \ /
      Last update: 2017-10-09 15:58    [W:4.024 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site