Messages in this thread | | | From | Masahiro Yamada <> | Date | Mon, 9 Oct 2017 21:02:55 +0900 | Subject | Re: [PATCH 10/12] net/mlx4: replace <linux/radix-tree.h> with <linux/radix-tree-root.h> |
| |
2017-10-09 2:32 GMT+09:00 Joe Perches <joe@perches.com>: > On Mon, 2017-10-09 at 02:29 +0900, Masahiro Yamada wrote: >> The idea is simple; include necessary headers explicitly. > > Try that for kernel.h > > There's a reason aggregation of #includes is useful. >
BTW, talking about <linux/kernel.h>, it is too much aggregation, isn't it?
It exceed 850 lines, and contains lots of unrelated stuff in one header. Perhaps, it could be a good time to think about splitting?
For example, I see many trace_... things in it.
I wonder if linux/kernel.h is a good home for them, or a separate file.
-- Best Regards Masahiro Yamada
| |