lkml.org 
[lkml]   [2017]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] arcmsr: Fix possible sleep-in-atomic bugs in arcmsr_queue_command
Date
The driver may sleep under a spinlock, and the function call paths are:
arcmsr_queue_command(acquire the spinlock)
arcmsr_queue_command_lck
arcmsr_handle_virtual_command
arcmsr_iop_message_xfer
arcmsr_iop_parking
arcmsr_stop_adapter_bgrb
arcmsr_hbaA_stop_bgrb
arcmsr_hbaA_wait_msgint_ready
msleep --> may sleep

arcmsr_queue_command(acquire the spinlock)
arcmsr_queue_command_lck
arcmsr_handle_virtual_command
arcmsr_iop_message_xfer
arcmsr_iop_parking
arcmsr_stop_adapter_bgrb
arcmsr_hbaB_stop_bgrb
arcmsr_hbaB_wait_msgint_ready
msleep --> may sleep

arcmsr_queue_command(acquire the spinlock)
arcmsr_queue_command_lck
arcmsr_handle_virtual_command
arcmsr_iop_message_xfer
arcmsr_iop_parking
arcmsr_stop_adapter_bgrb
arcmsr_hbaC_stop_bgrb
arcmsr_hbaC_wait_msgint_ready
msleep --> may sleep

arcmsr_queue_command(acquire the spinlock)
arcmsr_queue_command_lck
arcmsr_handle_virtual_command
arcmsr_iop_message_xfer
arcmsr_iop_parking
arcmsr_stop_adapter_bgrb
arcmsr_hbaD_stop_bgrb
arcmsr_hbaD_wait_msgint_ready
msleep --> may sleep

To fix them, msleep is replaced with mdelay.
These bugs are found by my static analysis tool and my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
---
drivers/scsi/arcmsr/arcmsr_hba.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index af032c4..31d94bd 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -347,7 +347,7 @@ static uint8_t arcmsr_hbaA_wait_msgint_ready(struct AdapterControlBlock *acb)
&reg->outbound_intstatus);
return true;
}
- msleep(10);
+ mdelay(10);
} /* max 20 seconds */

return false;
@@ -367,7 +367,7 @@ static uint8_t arcmsr_hbaB_wait_msgint_ready(struct AdapterControlBlock *acb)
reg->drv2iop_doorbell);
return true;
}
- msleep(10);
+ mdelay(10);
} /* max 20 seconds */

return false;
@@ -385,7 +385,7 @@ static uint8_t arcmsr_hbaC_wait_msgint_ready(struct AdapterControlBlock *pACB)
&phbcmu->outbound_doorbell_clear); /*clear interrupt*/
return true;
}
- msleep(10);
+ mdelay(10);
} /* max 20 seconds */

return false;
@@ -403,7 +403,7 @@ static bool arcmsr_hbaD_wait_msgint_ready(struct AdapterControlBlock *pACB)
reg->outbound_doorbell);
return true;
}
- msleep(10);
+ mdelay(10);
} /* max 20 seconds */
return false;
}
--
1.7.9.5

\
 
 \ /
  Last update: 2017-10-08 14:50    [W:0.026 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site