lkml.org 
[lkml]   [2017]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] configfs: Fix bool initialization/comparison
    From
    Date
    Bool initializations should use true and false. Bool tests don't need
    comparisons.

    Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
    ---

    diff -u -p a/fs/configfs/file.c b/fs/configfs/file.c
    --- a/fs/configfs/file.c
    +++ b/fs/configfs/file.c
    @@ -166,7 +166,7 @@ configfs_read_bin_file(struct file *file
    retval = -ETXTBSY;
    goto out;
    }
    - buffer->read_in_progress = 1;
    + buffer->read_in_progress = true;

    if (buffer->needs_read_fill) {
    /* perform first read with buf == NULL to get extent */
    @@ -325,7 +325,7 @@ configfs_write_bin_file(struct file *fil
    len = -ETXTBSY;
    goto out;
    }
    - buffer->write_in_progress = 1;
    + buffer->write_in_progress = true;

    /* buffer grows? */
    if (*ppos + count > buffer->bin_buffer_size) {
    @@ -429,8 +429,8 @@ static int check_perm(struct inode * ino
    }
    mutex_init(&buffer->mutex);
    buffer->needs_read_fill = 1;
    - buffer->read_in_progress = 0;
    - buffer->write_in_progress = 0;
    + buffer->read_in_progress = false;
    + buffer->write_in_progress = false;
    buffer->ops = ops;
    file->private_data = buffer;
    goto Done;
    @@ -488,10 +488,10 @@ static int configfs_release_bin_file(str
    ssize_t len = 0;
    int ret;

    - buffer->read_in_progress = 0;
    + buffer->read_in_progress = false;

    if (buffer->write_in_progress) {
    - buffer->write_in_progress = 0;
    + buffer->write_in_progress = false;

    len = bin_attr->write(item, buffer->bin_buffer,
    buffer->bin_buffer_size);
    \
     
     \ /
      Last update: 2017-10-07 16:24    [W:3.063 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site