lkml.org 
[lkml]   [2017]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] default implementation for of_find_all_nodes(...)
On Wed, Aug 30, 2017 at 1:32 PM, Artur Lorincz <larturus2@gmail.com> wrote:
> Added default implementation for of_find_all_nodes(). This function is
> used by board.c from the board module (drivers/staging/board).

Didn't even know we had this... The DT core already has some support
for something like this with "auxdata" that lets you attach DT nodes
to existing platform devices. Why doesn't that work?

In any case, you should just make this code depend on CONFIG_OF. When
there's only 3 other users of this function, that's a good sign we
don't want more. Searching thru all nodes is generally not the right
thing to do.

Rob

\
 
 \ /
  Last update: 2017-10-07 00:34    [W:0.081 / U:4.092 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site