lkml.org 
[lkml]   [2017]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1] i2c:i2c-stm32f7: fix setup structure
From
Date


On 10/05/2017 01:14 PM, Wolfram Sang wrote:
> On Thu, Sep 21, 2017 at 03:30:09PM +0200, Pierre-Yves MORDRET wrote:
>> I2C drive setup structure is not properly allocated.
>> Make it static instead of pointer to store driver data.
>>
>> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
>
> Ouch! How did it work before?

Well yes it did. When it has been discovered during internal code review I was
skeptical but it turned out to be true. I tested on STM32 F7/H7 without any
trouble : scary !

>
> Applied to for-current, thanks! Please provide a Fixes: tag next time,
> did this for you now.
>
Sorry I wasn't aware about that. I gonna remember for the next time.
Thanks !

Py

\
 
 \ /
  Last update: 2017-10-06 09:54    [W:0.035 / U:8.440 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site