lkml.org 
[lkml]   [2017]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] block: remove unnecessary NULL checks in bioset_integrity_free()
From
Date
Hi Tim,

On Oct 5, 2017, at 2:09 PM, Tim Hansen <devtimhansen@gmail.com> wrote:
>
> mempool_destroy() already checks for a NULL value being passed in, this eliminates duplicate checks.
>
> This was caught by running make coccicheck M=block/ on linus' tree on commit 77ede3a014a32746002f7889211f0cecf4803163 (current head as of this patch).
>
> Signed-off-by: Tim Hansen <devtimhansen@gmail.com>
> ---
> block/bio-integrity.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/block/bio-integrity.c b/block/bio-integrity.c
> index 5df3290..23b42e8 100644
> --- a/block/bio-integrity.c
> +++ b/block/bio-integrity.c
> @@ -485,11 +485,8 @@ EXPORT_SYMBOL(bioset_integrity_create);
>
> void bioset_integrity_free(struct bio_set *bs)
> {
> - if (bs->bio_integrity_pool)
> - mempool_destroy(bs->bio_integrity_pool);
> -
> - if (bs->bvec_integrity_pool)
> - mempool_destroy(bs->bvec_integrity_pool);
> + mempool_destroy(bs->bio_integrity_pool);
> + mempool_destroy(bs->bvec_integrity_pool);
> }
> EXPORT_SYMBOL(bioset_integrity_free);
>
> --
> 2.1.4

Looks good.

Reviewed-by: Kyle Fortin <kyle.fortin@oracle.com>


\
 
 \ /
  Last update: 2017-10-06 18:01    [W:0.048 / U:0.884 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site