Messages in this thread | | | Date | Fri, 6 Oct 2017 10:23:55 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH v4 01/27] linkage: new macros for assembler symbols |
| |
On Mon, Oct 02, 2017 at 11:12:20AM +0200, Jiri Slaby wrote: > SYM_CODE_INNER_LABEL -- only for labels in the middle of code > SYM_CODE_INNER_LABEL_NOALIGN -- only for labels in the middle of code
Why are the inner labels aligned by default? Seems like unaligned would be the most common case.
> > d) For data > SYM_DATA_START -- global data symbol > SYM_DATA_END -- the end of the SYM_DATA_START symbol > SYM_DATA_END_LABEL -- the labeled end of SYM_DATA_START symbol > SYM_DATA_SIMPLE -- start+end wrapper around simple global data > SYM_DATA_SIMPLE_LOCAL -- start+end wrapper around simple local data
"SIMPLE" seems superfluous, how about s/SYM_DATA_SIMPLE/SYM_DATA/ ?
-- Josh
| |