Messages in this thread | | | From | Javier González <> | Subject | Re: [PATCH] lightnvm: pblk: remove spinlock when freeing line metadata | Date | Fri, 6 Oct 2017 15:28:44 +0200 |
| |
> On 6 Oct 2017, at 11.20, Andrey Ryabinin <aryabinin@virtuozzo.com> wrote: > > On 10/05/2017 11:35 AM, Hans Holmberg wrote: >> From: Hans Holmberg <hans.holmberg@cnexlabs.com> >> >> Lockdep complains about being in atomic context while freeing line >> metadata - and rightly so as we take a spinlock and end up calling >> vfree that might sleep(in pblk_mfree). >> >> There is no need for holding the line manager free_lock while >> freeing line metadata, so remove the lock. >> >> Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com> > > Reviewed-by: Andrey Ryabinin <aryabinin@virtuozzo.com> > > I guess this also deserves stable tag. The bug was introduced in 4.13 by > commit 588726d3ec68 ("lightnvm: pblk: fail gracefully on irrec. error"). >
Good point. We'll add it when picking it up.
Thanks, Javier [unhandled content-type:application/pgp-signature] | |