lkml.org 
[lkml]   [2017]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 17/50] IB/ipoib: rtnl_unlock can not come after free_netdev
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Feras Daoud <ferasda@mellanox.com>


    [ Upstream commit 89a3987ab7a923c047c6dec008e60ad6f41fac22 ]

    The ipoib_vlan_add function calls rtnl_unlock after free_netdev,
    rtnl_unlock not only releases the lock, but also calls netdev_run_todo.
    The latter function browses the net_todo_list array and completes the
    unregistration of all its net_device instances. If we call free_netdev
    before rtnl_unlock, then netdev_run_todo call over the freed device causes
    panic.
    To fix, move rtnl_unlock call before free_netdev call.

    Fixes: 9baa0b036410 ("IB/ipoib: Add rtnl_link_ops support")
    Cc: Or Gerlitz <ogerlitz@mellanox.com>
    Signed-off-by: Feras Daoud <ferasda@mellanox.com>
    Signed-off-by: Erez Shitrit <erezsh@mellanox.com>
    Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
    Signed-off-by: Leon Romanovsky <leon@kernel.org>
    Signed-off-by: Doug Ledford <dledford@redhat.com>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/infiniband/ulp/ipoib/ipoib_vlan.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/infiniband/ulp/ipoib/ipoib_vlan.c
    +++ b/drivers/infiniband/ulp/ipoib/ipoib_vlan.c
    @@ -160,11 +160,11 @@ int ipoib_vlan_add(struct net_device *pd
    out:
    up_write(&ppriv->vlan_rwsem);

    + rtnl_unlock();
    +
    if (result)
    free_netdev(priv->dev);

    - rtnl_unlock();
    -
    return result;
    }


    \
     
     \ /
      Last update: 2017-10-06 11:09    [W:2.464 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site