lkml.org 
[lkml]   [2017]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v4 05/14] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver
Date
> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> Sent: Thursday, October 5, 2017 12:34 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: dvhart@infradead.org; LKML <linux-kernel@vger.kernel.org>; Platform Driver
> <platform-driver-x86@vger.kernel.org>; Andy Lutomirski <luto@kernel.org>;
> quasisec@google.com; Pali Rohár <pali.rohar@gmail.com>; Rafael J. Wysocki
> <rjw@rjwysocki.net>; mjg59@google.com; Christoph Hellwig <hch@lst.de>;
> Greg KH <greg@kroah.com>
> Subject: Re: [PATCH v4 05/14] platform/x86: dell-wmi-descriptor: split WMI
> descriptor into it's own driver
>
> On Thu, Oct 5, 2017 at 1:48 AM, Mario Limonciello
> <mario.limonciello@dell.com> wrote:
> > All communication on individual GUIDs should occur in separate drivers.
> > Allowing a driver to communicate with the bus to another GUID is just
> > a hack that discourages drivers to adopt the bus model.
> >
> > The information found from the WMI descriptor driver is now exported
> > for use by other drivers.
>
> > + priv = list_first_entry_or_null(&wmi_list,
> > + struct descriptor_priv,
> > + list);
>
> > + priv = list_first_entry_or_null(&wmi_list,
> > + struct descriptor_priv,
> > + list);
>
> static inline ...to_priv(...)
> {
> return list_first_entry_...();
> }
>
> > + list_add_tail(&priv->list, &wmi_list);
>
> > + list_del(&priv->list);
>
> Do these need locking?

Yeah this seems like a good idea. I'll add it in.

>
> > +bool dell_wmi_get_interface_version(u32 *version);
> > +bool dell_wmi_get_size(u32 *size);
>
> This might need stubs when module is not selected (when functionality
> is optional if it would be the case), otherwise all users should
> select it explicitly.

Per Darren's other threads I'm adjusting Kconfig to make sure this module
is selected. It's realistically not optional when using these others.
\
 
 \ /
  Last update: 2017-10-05 19:05    [W:0.097 / U:1.396 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site