lkml.org 
[lkml]   [2017]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] switchtec: make struct event_regs static
Thanks!

Acked-by: Logan Gunthorpe <logang@deltatee.com>

On 10/5/2017 4:01 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The structure event_regs is local to the source and does not need to
> be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'event_regs' was not declared. Should it be static
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/pci/switch/switchtec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
> index af81b2dec42e..da45dbea20ce 100644
> --- a/drivers/pci/switch/switchtec.c
> +++ b/drivers/pci/switch/switchtec.c
> @@ -943,7 +943,7 @@ static u32 __iomem *pff_ev_reg(struct switchtec_dev *stdev,
> #define EV_PAR(i, r)[i] = {offsetof(struct part_cfg_regs, r), part_ev_reg}
> #define EV_PFF(i, r)[i] = {offsetof(struct pff_csr_regs, r), pff_ev_reg}
>
> -const struct event_reg {
> +static const struct event_reg {
> size_t offset;
> u32 __iomem *(*map_reg)(struct switchtec_dev *stdev,
> size_t offset, int index);
>

\
 
 \ /
  Last update: 2017-10-05 17:38    [W:0.036 / U:2.044 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site