lkml.org 
[lkml]   [2017]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v4 04/14] platform/x86: dell-wmi: increase severity of some failures
Date
> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> Sent: Thursday, October 5, 2017 12:21 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: dvhart@infradead.org; LKML <linux-kernel@vger.kernel.org>; Platform Driver
> <platform-driver-x86@vger.kernel.org>; Andy Lutomirski <luto@kernel.org>;
> quasisec@google.com; Pali Rohár <pali.rohar@gmail.com>; Rafael J. Wysocki
> <rjw@rjwysocki.net>; mjg59@google.com; Christoph Hellwig <hch@lst.de>;
> Greg KH <greg@kroah.com>
> Subject: Re: [PATCH v4 04/14] platform/x86: dell-wmi: increase severity of some
> failures
>
> On Thu, Oct 5, 2017 at 1:48 AM, Mario Limonciello
> <mario.limonciello@dell.com> wrote:
> > There is a lot of error checking in place for the format of the WMI
> > descriptor buffer, but some of the potentially raised issues should
> > be considered critical failures.
> >
> > If the buffer size or header don't match, this is a good indication
> > that the buffer format changed in a way that the rest of the data
> > should not be relied upon.
> >
> > For the remaining data set vectors, continue to notate a warning
> > in undefined results, but as those are fields that the descriptor
> > intended to refer to other applications, don't fail if they're new
> > values.
>
> > - if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0)
> > - dev_warn(&wdev->dev, "Dell descriptor buffer has invalid signature
> (%8ph)\n",
> > + if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0) {
> > + dev_err(&wdev->dev, "Dell descriptor buffer has invalid signature
> (%8ph)\n",
>
> A nit: ping-pong programming detected.
> Looks like current patch 2 should go at least after this one.
>
>
> --

I'll re-order them, but either way both patches are touching these lines in some
way.
\
 
 \ /
  Last update: 2017-10-05 17:03    [W:0.109 / U:9.008 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site