[lkml]   [2017]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 08/14] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens
On Thu, Oct 5, 2017 at 4:58 PM,  <> wrote:

>> > Suggested-by: Andy Shevchenko <>
>> To be clear I just suggested the output format in ->show() callback.
> Andy, do you mean you would prefer not to be attributed in the description,
> or should I be clearer that was your suggestion?

I think that there is bigger threshold for being included one's name
in Suggested-by tag. You have few dozens of lines changed and only one
is suggested by me. And that one doesn't influence the initial idea,
just a format change.

So, I'm not against it per se, I just think it confuses more than attributes.

Summarize: I would not put it in this patch.

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2017-10-05 16:22    [W:0.064 / U:2.796 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site