lkml.org 
[lkml]   [2017]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Intel-gfx] [PATCH] drm/i915/selftests: fix check for intel IOMMU
On Thu, Oct 05, 2017 at 01:17:11PM +0100, Chris Wilson wrote:
> Quoting Arnd Bergmann (2017-10-05 13:07:22)
> > An earlier bugfix tried to work around this build failure:
> >
> > drivers/gpu/drm/i915/selftests/mock_gem_device.c: In function 'mock_gem_device':
> > drivers/gpu/drm/i915/selftests/mock_gem_device.c:151:20: error: 'struct dev_archdata' has no member named 'iommu'
> >
> > Checking for CONFIG_IOMMU_API is not sufficient as a compile-time
> > test since that may be enabled in configurations that have neither
> > INTEL_IOMMU not AMD_IOMMU enabled. This changes the check to
> > INTEL_IOMMU instead, as this is the only case we actually care about.
> >
> > Fixes: f46f156ea770 ("drm/i915/selftests: Only touch archdata.iommu when it exists")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I'll take your wisdom. I was lost trying to nail down exactly what
> config options we needed to check and settled for something that
> appeared good enough (for the small selection of configs I tested).
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Pushed, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

\
 
 \ /
  Last update: 2017-10-05 15:26    [W:0.037 / U:0.844 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site