lkml.org 
[lkml]   [2017]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] powerpc: Drop lockdep_assert_cpus_held call from arch_update_cpu_topology
On Wed, 4 Oct 2017, Thiago Jung Bauermann wrote:

> It turns out that not all paths calling arch_update_cpu_topology hold
> cpu_hotplug_lock, but that's ok because those paths aren't supposed to race
> with any concurrent hotplug events.
>
> Callers of arch_update_cpu_topology are expected to know what they are
> doing when they call the function without holding the lock, so remove the
> lockdep warning.

"Expected to know what they are doing" is not really a good approach as
it's way too simple to screw things up.

You might consider to have two functions where one does the check and the
other does not, but I leave that to the PPC maintainers.

Thanks,

tglx

\
 
 \ /
  Last update: 2017-10-05 14:39    [W:0.083 / U:3.220 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site