[lkml]   [2017]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 04/14] platform/x86: dell-wmi: increase severity of some failures
On Thu, Oct 5, 2017 at 1:48 AM, Mario Limonciello
<> wrote:
> There is a lot of error checking in place for the format of the WMI
> descriptor buffer, but some of the potentially raised issues should
> be considered critical failures.
> If the buffer size or header don't match, this is a good indication
> that the buffer format changed in a way that the rest of the data
> should not be relied upon.
> For the remaining data set vectors, continue to notate a warning
> in undefined results, but as those are fields that the descriptor
> intended to refer to other applications, don't fail if they're new
> values.

> - if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0)
> - dev_warn(&wdev->dev, "Dell descriptor buffer has invalid signature (%8ph)\n",
> + if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0) {
> + dev_err(&wdev->dev, "Dell descriptor buffer has invalid signature (%8ph)\n",

A nit: ping-pong programming detected.
Looks like current patch 2 should go at least after this one.

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2017-10-05 07:21    [W:0.398 / U:4.172 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site