lkml.org 
[lkml]   [2017]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/9 v2] usb: usb251xb: Add USB2517i specific struct and IDs
From
Date
Hi Serge,

On 09/16/2017 12:42 PM, Serge Semin wrote:
> There are USB2517 and USB2517i hubs, which have almost the same
> registers space as already supported USB251xbi series. The difference
> it in DIDs and in few functions. This patch adds the USB2517/i data
> structures to the driver, so it would have different setting depending
> on the device discovered on i2c-bus.
>
> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
> ---
> Documentation/devicetree/bindings/usb/usb251xb.txt | 3 ++-
> drivers/usb/misc/usb251xb.c | 21 ++++++++++++++++++++-
> 2 files changed, 22 insertions(+), 2 deletions(-)

...

Please also mention support for the USB2517(i) hubs in the Kconfig
helptext of the driver @ drivers/usb/misc/Kconfig. Thanks.

Apart from that the patch looks good to me.

regards,
Richard.L

\
 
 \ /
  Last update: 2017-10-04 09:39    [W:0.189 / U:0.936 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site