lkml.org 
[lkml]   [2017]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [v10 4/6] mm, oom: introduce memory.oom_group
    On Wed, Oct 04, 2017 at 04:46:36PM +0100, Roman Gushchin wrote:
    > The cgroup-aware OOM killer treats leaf memory cgroups as memory
    > consumption entities and performs the victim selection by comparing
    > them based on their memory footprint. Then it kills the biggest task
    > inside the selected memory cgroup.
    >
    > But there are workloads, which are not tolerant to a such behavior.
    > Killing a random task may leave the workload in a broken state.
    >
    > To solve this problem, memory.oom_group knob is introduced.
    > It will define, whether a memory group should be treated as an
    > indivisible memory consumer, compared by total memory consumption
    > with other memory consumers (leaf memory cgroups and other memory
    > cgroups with memory.oom_group set), and whether all belonging tasks
    > should be killed if the cgroup is selected.
    >
    > If set on memcg A, it means that in case of system-wide OOM or
    > memcg-wide OOM scoped to A or any ancestor cgroup, all tasks,
    > belonging to the sub-tree of A will be killed. If OOM event is
    > scoped to a descendant cgroup (A/B, for example), only tasks in
    > that cgroup can be affected. OOM killer will never touch any tasks
    > outside of the scope of the OOM event.
    >
    > Also, tasks with oom_score_adj set to -1000 will not be killed.
    >
    > The default value is 0.
    >
    > Signed-off-by: Roman Gushchin <guro@fb.com>
    > Cc: Michal Hocko <mhocko@kernel.org>
    > Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
    > Cc: Johannes Weiner <hannes@cmpxchg.org>
    > Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
    > Cc: David Rientjes <rientjes@google.com>
    > Cc: Andrew Morton <akpm@linux-foundation.org>
    > Cc: Tejun Heo <tj@kernel.org>
    > Cc: kernel-team@fb.com
    > Cc: cgroups@vger.kernel.org
    > Cc: linux-doc@vger.kernel.org
    > Cc: linux-kernel@vger.kernel.org
    > Cc: linux-mm@kvack.org

    Those semantics make sense to me and the code looks good.

    Acked-by: Johannes Weiner <hannes@cmpxchg.org>

    \
     
     \ /
      Last update: 2017-10-04 21:38    [W:4.493 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site