lkml.org 
[lkml]   [2017]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/3] iwlwifi: cosmetic fixes
From
Date
On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote:
> Fix several code style issues, some of which were reported by
> checkpatch.pl.
>
> The changes are:
> * One instance of an `int` variable being used in a boolean context,
> chaned to
> use the more appropriate `bool` type.
> * One very minor fix, removing a newline between a function
> definition and its
> associated `static` keyword
> * One fix wrapping a macro in curly braces
>
>
> Christoph Böhmwalder (3):
> wireless: iwlwifi: use bool instead of int
> wireless: iwlwifi: function definition cosmetic fix
> wireless: iwlwifi: wrap macro into braces
>
> drivers/net/wireless/intel/iwlwifi/iwl-io.c | 2 +-
> drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c | 16 +++++++------
> ---
> 2 files changed, 8 insertions(+), 10 deletions(-)

Sorry, but this kind of series just generates churn. Especially when 2
out of 3 patches are broken. I applied your previous patch because it
was really trivial, but I really don't want to encourage this kind of
drive-by "fixes" that only cause additional work.

I generally only accept this kind of changes when people are changing
code close or related to it.

--
Luca.

\
 
 \ /
  Last update: 2017-10-04 18:21    [W:0.021 / U:23.588 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site