lkml.org 
[lkml]   [2017]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] nvmem: imx-ocotp: read uniq CPU ID and export as system serial number
On Wed, Oct 04, 2017 at 05:16:16PM +0200, Marcus Folkesson wrote:
> The uniq ID is usually exported as ATAG_SERIAL but in case of
> devicetrees, this information is not passed.
>
> The uniq ID is stored in OCOTP memory (bank 0, Word 1,2) on imx CPUs.
> Read the ID and set as system serial number.
>
> This function is activated by setting `read-system-serial`
> dt property for the imx-ocotp node.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
>
> Comment:
> I'm not sure if this functionality really should be in a device driver.
> Maybe it should be in arch/arm/mach-imx/. However, it's not
> completely wrong so I give it a shot.
>
> .../devicetree/bindings/nvmem/imx-ocotp.txt | 1 +
> drivers/nvmem/imx-ocotp.c | 38 ++++++++++++++++++++++
> 2 files changed, 39 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> index 70d791b03ea1..bf0cc9e5e50f 100644
> --- a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
> @@ -16,6 +16,7 @@ Required properties:
>
> Optional properties:
> - read-only: disable write access
> +- read-system-serial: read uniq ID and export as system serial number. Available in /proc/cpuinfo

As described, this is a pure SW option (

/proc/cpuinfo is a not a HW detail, and whether or not to export this
information there is a policy. So as described, this shouldn't be in the
DT.

Are you just trying to describe whether hte information is available in
the OCOTP memory?

e.g. maybe this should be something like:

- has-unique-id: OCOTP bank0, Words 1 & 2 contain a unique ID
identifying the system.

Thanks,
Mark.

\
 
 \ /
  Last update: 2017-10-04 17:46    [W:0.049 / U:4.328 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site