lkml.org 
[lkml]   [2017]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Outreachy kernel] [PATCH 3/3] evaluate: make pointers in string arrays constant
On Mon, Oct 02, 2017 at 01:02:50PM +0530, Harsha Sharma wrote:
> static const char * array should probably be static const char * const
> array
> as per linux-kernel coding style
>
> Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
> ---
> src/evaluate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/evaluate.c b/src/evaluate.c
> index b783054..f48801a 100644
> --- a/src/evaluate.c
> +++ b/src/evaluate.c
> @@ -33,7 +33,7 @@
> static struct output_ctx octx_debug_dummy;
> static int expr_evaluate(struct eval_ctx *ctx, struct expr **expr);
>
> -static const char *byteorder_names[] = {
> +static const char * const byteorder_names[] = {

I can see more string array that could use this in the nftables tree.
Please, fix all in one single patch.

Thanks.

\
 
 \ /
  Last update: 2017-10-04 16:30    [W:0.072 / U:30.616 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site