lkml.org 
[lkml]   [2017]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUG] scsi/fcoe: Sleep-in-atomic bugs in fcoe driver
On Tue, Oct 03, 2017 at 11:02:33AM +0800, Jia-Ju Bai wrote:
> According to fcoe_ctlr.c, the driver may sleep under a RCU lock,
> and the function call paths are:
> fcoe_ctlr_disc_stop_locked (acquire the RCU lock)
> fc_rport_logoff
> mutex_lock --> may sleep
>
> fcoe_ctlr_vn_disc
> fc_rport_login
> mutex_lock --> may sleep
>
> fcoe_ctlr_vn_age
> fc_rport_logoff
> mutex_lock --> may sleep
>
> These bugs are found by my static analysis tool and my code review.
>
> Thanks,
> Jia-Ju Bai
>

Thanks for the report, coincidentally I have a bug report for this as well (in
a real setup not just static analysis) and gave the reporter a patch to test.
Once it's verified I'll post it here.

Thanks,
Johannes

--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

\
 
 \ /
  Last update: 2017-10-04 12:07    [W:0.030 / U:5.836 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site