lkml.org 
[lkml]   [2017]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v8 2/6] vfs: Remove unnecessary list_for_each_entry_safe() variants
    Date
    From: Jan Kara <jack@suse.cz>

    evict_inodes() and invalidate_inodes() use list_for_each_entry_safe()
    to iterate sb->s_inodes list. However, since we use i_lru list entry for
    our local temporary list of inodes to destroy, the inode is guaranteed
    to stay in sb->s_inodes list while we hold sb->s_inode_list_lock. So
    there is no real need for safe iteration variant and we can use
    list_for_each_entry() just fine.

    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Waiman Long <longman@redhat.com>
    ---
    fs/inode.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/fs/inode.c b/fs/inode.c
    index fd40102..a9a38c0 100644
    --- a/fs/inode.c
    +++ b/fs/inode.c
    @@ -601,12 +601,12 @@ static void dispose_list(struct list_head *head)
    */
    void evict_inodes(struct super_block *sb)
    {
    - struct inode *inode, *next;
    + struct inode *inode;
    LIST_HEAD(dispose);

    again:
    spin_lock(&sb->s_inode_list_lock);
    - list_for_each_entry_safe(inode, next, &sb->s_inodes, i_sb_list) {
    + list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
    if (atomic_read(&inode->i_count))
    continue;

    @@ -652,11 +652,11 @@ void evict_inodes(struct super_block *sb)
    int invalidate_inodes(struct super_block *sb, bool kill_dirty)
    {
    int busy = 0;
    - struct inode *inode, *next;
    + struct inode *inode;
    LIST_HEAD(dispose);

    spin_lock(&sb->s_inode_list_lock);
    - list_for_each_entry_safe(inode, next, &sb->s_inodes, i_sb_list) {
    + list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
    spin_lock(&inode->i_lock);
    if (inode->i_state & (I_NEW | I_FREEING | I_WILL_FREE)) {
    spin_unlock(&inode->i_lock);
    --
    1.8.3.1
    \
     
     \ /
      Last update: 2017-10-31 19:52    [W:3.418 / U:0.448 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site