lkml.org 
[lkml]   [2017]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v2 0/5] PM / Domains: Remove gpd_dev_ops.active_wakeup() callback
Date
	Hi Rafael, Ulf, Kevin,

It is quite common for PM Domains to require slave devices to be kept
active during system suspend if they are to be used as wakeup sources.
To enable this, currently each PM Domain or driver has to provide its
own gpd_dev_ops.active_wakeup() callback.

All existing callbacks either return always true, or a fixed value
depending on the PM Domain.

Hence this patch series simplifies active wakeup handling by replacing
the callback by a flag:
- Patch 1 adds a new new flag GENPD_FLAG_ACTIVE_WAKEUP, to be set by
PM Domain drivers that want to use the new handling,
- Patches 2-4 convert all existing users of the callback to the new
flag,
- Patch 5 removes the callback.

This series was extracted from "[PATCH 00/10] PM / Domain: renesas: Fix
active wakeup behavior", and retains only PM Domain changes to existing
drivers.
Changes compared to v1 (most suggested by Ulf):
- Use the flag in se instead of setting up an "always true" callback,
- Convert the mediatek and rockchip PM Domain drivers,
- Remove the callback.

If this idea is accepted, I think it would be good to still queue the first
patch for v4.15. That would allow the changes to the PM Domain drivers
to go in through the respective platform trees in v4.16.
Then the final patch has to be postponed until v4.17.
Alternatively, everything can go in through the PM tree in one shot.

Thanks for your comments!

Geert Uytterhoeven (5):
PM / Domains: Allow genpd users to specify default active wakeup
behavior
[RFC] ARM: shmobile: pm-rmobile: Use GENPD_FLAG_ACTIVE_WAKEUP
[RFC] soc: mediatek: Use GENPD_FLAG_ACTIVE_WAKEUP
[RFC] soc: rockchip: power-domain: Use GENPD_FLAG_ACTIVE_WAKEUP
[RFC] PM / Domains: Remove gpd_dev_ops.active_wakeup() callback

arch/arm/mach-shmobile/pm-rmobile.c | 8 +-------
drivers/base/power/domain.c | 13 ++++---------
drivers/soc/mediatek/mtk-scpsys.c | 14 ++------------
drivers/soc/rockchip/pm_domains.c | 14 ++------------
include/linux/pm_domain.h | 8 ++++----
5 files changed, 13 insertions(+), 44 deletions(-)

--
2.7.4

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2017-10-31 19:12    [W:0.087 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site