Messages in this thread | | | Date | Tue, 31 Oct 2017 08:24:06 -0700 | From | Darren Hart <> | Subject | Re: [PATCH v11 08/15] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens |
| |
On Mon, Oct 30, 2017 at 01:36:16PM +0000, Mario.Limonciello@dell.com wrote: > > > > Hint: you can move this check out of j-loop as condition is independent > > of it. > > That's true, thanks. > > > > > Also how many tokens are there? Is not quadratic solution too slow? > > > > ~< 250 on most machines is what I've seen. To me that that's a small > enough number that this is quick. It only happens at initialization.
Agreed, not a hot path. Prefer simplicity to performance here.
-- Darren Hart VMware Open Source Technology Center
| |