lkml.org 
[lkml]   [2017]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v11 08/15] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens
On Mon, Oct 30, 2017 at 01:36:16PM +0000, Mario.Limonciello@dell.com wrote:
> >
> > Hint: you can move this check out of j-loop as condition is independent
> > of it.
>
> That's true, thanks.
>
> >
> > Also how many tokens are there? Is not quadratic solution too slow?
> >
>
> ~< 250 on most machines is what I've seen. To me that that's a small
> enough number that this is quick. It only happens at initialization.

Agreed, not a hot path. Prefer simplicity to performance here.

--
Darren Hart
VMware Open Source Technology Center

\
 
 \ /
  Last update: 2017-10-31 16:24    [W:0.329 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site