lkml.org 
[lkml]   [2017]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/5] wlcore: Use common error handling code in wlcore_nvs_cb()
From
Date
>> @@ -6551,6 +6549,11 @@ static void wlcore_nvs_cb(const struct firmware *fw, void *context)
>> out:
>> release_firmware(fw);
>> complete_all(&wl->nvs_loading_complete);
>> + return;
>> +
>> +power_off:
>
> Name this "out_power_off" to match the other labels.

Do you expect a second approach for this patch series then?


>> + wl1271_power_off(wl);
>> + goto out_free_nvs;
>
> Why not put this in front of the out_free_nvs label?

It seems that I can not really follow this suggestion at the moment.


> It looks weird here.

Which detail do you not like?

Regards,
Markus

\
 
 \ /
  Last update: 2017-10-30 14:41    [W:1.525 / U:1.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site