Messages in this thread | | | Subject | Re: [PATCH 1/5] wlcore: Use common error handling code in wlcore_nvs_cb() | From | SF Markus Elfring <> | Date | Mon, 30 Oct 2017 14:40:25 +0100 |
| |
>> @@ -6551,6 +6549,11 @@ static void wlcore_nvs_cb(const struct firmware *fw, void *context) >> out: >> release_firmware(fw); >> complete_all(&wl->nvs_loading_complete); >> + return; >> + >> +power_off: > > Name this "out_power_off" to match the other labels.
Do you expect a second approach for this patch series then?
>> + wl1271_power_off(wl); >> + goto out_free_nvs; > > Why not put this in front of the out_free_nvs label?
It seems that I can not really follow this suggestion at the moment.
> It looks weird here.
Which detail do you not like?
Regards, Markus
| |