Messages in this thread | | | Date | Mon, 30 Oct 2017 15:15:09 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] mmc: vub300: Use common code in __download_offload_pseudocode() |
| |
On Mon, Oct 30, 2017 at 12:40:39PM +0100, Ulf Hansson wrote: > On 27 October 2017 at 21:31, SF Markus Elfring > <elfring@users.sourceforge.net> wrote: > > From: Markus Elfring <elfring@users.sourceforge.net> > > Date: Fri, 27 Oct 2017 21:21:40 +0200 > > > > Add a jump target so that a specific string copy operation is stored > > only once at the end of this function implementation. > > Replace two calls of the function "strncpy" by goto statements. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > > Thanks, applied for next! >
What's the advantage of this patch? The new code seems more complicated to me and GCC automatically reuses duplicate constant strings so there is no memory savings.
regards, dan capenter
| |