lkml.org 
[lkml]   [2017]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Documentation: Improve softlockup_panic= description text
On Tue,  3 Oct 2017 17:54:07 +0200
Borislav Petkov <bp@alien8.de> wrote:

> It should say what that <integer> range is and what that integer value
> means. I had to look at the code...
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> ---
> Documentation/admin-guide/kernel-parameters.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 9a84483db403..c14cd2645c1f 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -3887,6 +3887,12 @@
> [KNL] Should the soft-lockup detector generate panics.
> Format: <integer>
>
> + A non-null value "instructs" the soft-lockup detector
> + to panic the machine when a soft-lockup occurs. This
> + is also controlled by CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC
> + which is the respective build-time switch to that
> + functionality.

So I hate to be fussy. (OK, perhaps I like it, but I'll act reluctant
anyway...:) If it's an integer value, how can it be null? Can we say "a
non-zero value" instead? I'd take out the quotes too, but that's extra
credit...

Thanks,

jon

\
 
 \ /
  Last update: 2017-10-03 22:40    [W:0.292 / U:1.296 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site