lkml.org 
[lkml]   [2017]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE
Date


> -----Original Message-----
> From: Devel [mailto:devel-bounces@acpica.org] On Behalf Of Rafael J.
> Wysocki
> Sent: Tuesday, October 3, 2017 9:05 AM
> To: Colin Ian King <colin.king@canonical.com>
> Cc: Wysocki, Rafael J <rafael.j.wysocki@intel.com>; Rafael J. Wysocki
> <rjw@rjwysocki.net>; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>; ACPI Devel Maling List <linux-
> acpi@vger.kernel.org>; Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>;
> devel@acpica.org
> Subject: Re: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE
>
> On Tue, Oct 3, 2017 at 2:34 PM, Colin Ian King
> <colin.king@canonical.com> wrote:
> > On 03/10/17 12:39, Rafael J. Wysocki wrote:
> >> On Tuesday, October 3, 2017 3:16:22 AM CEST Jérémy Lefaure wrote:
> >>> On Mon, 02 Oct 2017 14:27:52 +0200
> >>> "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
> >>>
> >>>> ACPICA is soewhat special code, though and I'm not taking or ACKing
> >>>> patches for it directly as a rule.
> >>>>
> >>>> For one, I'm not sure if ACPICA can use ARRAY_SIZE at all.
> >>> Why is it special code that can't use ARRAY_SIZE ? Is it because
> >>> this macro is defined in linux/kernel.h ?
> >
> > However, ACPICA does have ACPI_ARRAY_LENGTH(x), see
> > source/include/actypes.h
>
> Fair enough, but that cleanup should go in via ACPICA upstream anyway.
[Moore, Robert]

This would be acceptable, as long as it will work properly in the cases that were presented earlier (using ARRAY_SIZE).


>
> Thanks,
> Rafael
> _______________________________________________
> Devel mailing list
> Devel@acpica.org
> https://lists.acpica.org/mailman/listinfo/devel
\
 
 \ /
  Last update: 2017-10-03 18:39    [W:0.070 / U:5.492 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site