lkml.org 
[lkml]   [2017]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v9 03/12] mm: deferred_init_memmap improvements
From
Date
Hi Michal,

>
> Please be explicit that this is possible only because we discard
> memblock data later after 3010f876500f ("mm: discard memblock data
> later"). Also be more explicit how the new code works.

OK

>
> I like how the resulting code is more compact and smaller.

That was the goal :)

> for_each_free_mem_range also looks more appropriate but I really detest
> the DEFERRED_FREE thingy. Maybe we can handle all that in a single goto
> section. I know this is not an art but manipulating variables from
> macros is more error prone and much more ugly IMHO.

Sure, I can re-arrange to have a goto place. Function won't be as small,
and if compiler is not smart enough we might end up with having more
branches than what my current code has.

>
> please do not use macros. Btw. this deserves its own fix. I suspect that
> no CONFIG_HOLES_IN_ZONE arch enables DEFERRED_STRUCT_PAGE_INIT but
> purely from the review point of view it should be its own patch.

Sure, I will submit this patch separately from the rest of the project.
In my opinion DEFERRED_STRUCT_PAGE_INIT is the way of the future, so we
should make sure it is working with as many configs as possible.

Thank you,
Pasha

\
 
 \ /
  Last update: 2017-10-03 17:18    [W:0.069 / U:5.260 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site