lkml.org 
[lkml]   [2017]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v9 01/12] x86/mm: setting fields in deferred pages
From
Date
Hi Michal,

>
> I hope I haven't missed anything but it looks good to me.
>
> Acked-by: Michal Hocko <mhocko@suse.com>

Thank you for your review.

>
> one nit below
>> ---
>> arch/x86/mm/init_64.c | 9 +++++++--
>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
>> index 5ea1c3c2636e..30fe22558720 100644
>> --- a/arch/x86/mm/init_64.c
>> +++ b/arch/x86/mm/init_64.c
>> @@ -1182,12 +1182,17 @@ void __init mem_init(void)
>>
>> /* clear_bss() already clear the empty_zero_page */
>>
>> - register_page_bootmem_info();
>> -
>> /* this will put all memory onto the freelists */
>> free_all_bootmem();
>> after_bootmem = 1;
>>
>> + /* Must be done after boot memory is put on freelist, because here we
>
> standard code style is to do
> /*
> * text starts here

OK, will change for both patch 1 and 2.

Pasha

\
 
 \ /
  Last update: 2017-10-03 17:09    [W:0.078 / U:2.728 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site