lkml.org 
[lkml]   [2017]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 05/64] mac80211_hwsim: Use proper TX power
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Beni Lev <beni.lev@intel.com>

    commit 9de981f507474f326e42117858dc9a9321331ae5 upstream.

    In struct ieee80211_tx_info, control.vif pointer and rate_driver_data[0]
    falls on the same place, depending on the union usage.
    During the whole TX process, the union is referred to as a control struct,
    which holds the vif that is later used in the tx flow, especially in order
    to derive the used tx power.
    Referring direcly to rate_driver_data[0] and assigning a value to it,
    overwrites the vif pointer, hence making all later references irrelevant.
    Moreover, rate_driver_data[0] isn't used later in the flow in order to
    retrieve the channel that it is pointing to.

    Signed-off-by: Beni Lev <beni.lev@intel.com>
    Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/mac80211_hwsim.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/drivers/net/wireless/mac80211_hwsim.c
    +++ b/drivers/net/wireless/mac80211_hwsim.c
    @@ -1357,8 +1357,6 @@ static void mac80211_hwsim_tx(struct iee
    txi->control.rates,
    ARRAY_SIZE(txi->control.rates));

    - txi->rate_driver_data[0] = channel;
    -
    if (skb->len >= 24 + 8 &&
    ieee80211_is_probe_resp(hdr->frame_control)) {
    /* fake header transmission time */

    \
     
     \ /
      Last update: 2017-10-03 15:03    [W:3.606 / U:2.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site