lkml.org 
[lkml]   [2017]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE
From
Date
On 03/10/17 12:39, Rafael J. Wysocki wrote:
> On Tuesday, October 3, 2017 3:16:22 AM CEST Jérémy Lefaure wrote:
>> On Mon, 02 Oct 2017 14:27:52 +0200
>> "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
>>
>>> ACPICA is soewhat special code, though and I'm not taking or ACKing patches
>>> for it directly as a rule.
>>>
>>> For one, I'm not sure if ACPICA can use ARRAY_SIZE at all.
>> Why is it special code that can't use ARRAY_SIZE ? Is it because this
>> macro is defined in linux/kernel.h ?

However, ACPICA does have ACPI_ARRAY_LENGTH(x), see source/include/actypes.h

>
> Basically, yes.
>
> ACPICA is a separate project and the kernel acquires its source code from
> the upstream (which is used by other OSes too). That is not the case for
> any other code in the kernel I know about.
>
>
> We strive to keep the ACPICA code in the kernel as close to the upstream as
> reasonably possible for maintenance reasons, so we avoid doing Linux-specific
> things in it.
>
> As a rule of thumb, if you do cleanups like this one, better avoid the ACPICA
> code. :-)
>
> Thanks,
> Rafael
>
> _______________________________________________
> Devel mailing list
> Devel@acpica.org
> https://lists.acpica.org/mailman/listinfo/devel
>

\
 
 \ /
  Last update: 2017-10-03 14:35    [W:0.076 / U:2.596 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site