lkml.org 
[lkml]   [2017]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] firmware: google: make structure gsmi_dev static
On Tue,  3 Oct 2017 09:40:48 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The structure gsmi_dev is local to the source and does not need to be
> in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'gsmi_dev' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/firmware/google/gsmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
> index c8f169bf2e27..734146eec1b9 100644
> --- a/drivers/firmware/google/gsmi.c
> +++ b/drivers/firmware/google/gsmi.c
> @@ -84,7 +84,7 @@ struct gsmi_buf {
> u32 address; /* physical address of buffer */
> };
>
> -struct gsmi_device {
> +static struct gsmi_device {
> struct platform_device *pdev; /* platform device */
> struct gsmi_buf *name_buf; /* variable name buffer */
> struct gsmi_buf *data_buf; /* generic data buffer */

Acked-by: Jean Delvare <jdelvare@suse.de>

Thanks,
--
Jean Delvare
SUSE L3 Support

\
 
 \ /
  Last update: 2017-10-03 14:20    [W:0.031 / U:3.084 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site