lkml.org 
[lkml]   [2017]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey
Date
On 9/30/2017 9:13 PM, John Youn wrote:
> On 09/20/2017 12:57 PM, John Stultz wrote:
>> So here are a few dwc2 fixes that I've been using with HiKey.
>> I'm not totally sure these are all ideal, but they avoid edge case
>> issues that we have been running into with switching between
>> gadget mode and host mode.
>>
>> I'd guess the first two are potentially -stable material, and
>> the last might be worth sending to -stable too, as its a relatively
>> simple fix, but to my understanding the UDC state tracking has
>> always been broken so its not really a regression. But still.
>>
>> I'd love to get some feedback on the patches and consideration
>> to be merged upstream.
>>
>> thanks
>> -john
>>
>> Cc: Wei Xu <xuwei5@hisilicon.com>
>> Cc: Guodong Xu <guodong.xu@linaro.org>
>> Cc: Amit Pundir <amit.pundir@linaro.org>
>> Cc: YongQin Liu <yongqin.liu@linaro.org>
>> Cc: John Youn <johnyoun@synopsys.com>
>> Cc: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
>> Cc: Douglas Anderson <dianders@chromium.org>
>> Cc: Chen Yu <chenyu56@huawei.com>
>> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: linux-usb@vger.kernel.org
>>
>> John Stultz (3):
>> usb: dwc2: Improve gadget state disconnection handling
>> usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode
>> usb: dwc2: Fix UDC state tracking
>>
>> drivers/usb/dwc2/gadget.c | 7 +++++++
>> drivers/usb/dwc2/hcd.c | 8 ++++++--
>> 2 files changed, 13 insertions(+), 2 deletions(-)
>>
>
> Hi John,
>
> I think we have something that fixes these issues.
>
> Minas,
>
> Could you take a look at this? I was not able to find the patches we
> talked about. If possible, please post them so that John can try them
> out.
>
> Thanks,
> John
>
Hi John Stultz,

Could you please apply patch from Vardan Mikayelyan "usb: dwc2: Fix
dwc2_hsotg_core_init_disconnected()" submitted at 02/25/2017
(https://marc.info/?l=linux-usb&m=148801589931039&w=2) instead of your
"usb: dwc2: Improve gadget state disconnection handling" and test again
failing scenario.
Other 2 patches from series "[PATCH 0/3] dwc2 fixes for edge cases on
hikey" are Ok.

Thanks,
Minas

\
 
 \ /
  Last update: 2017-10-03 11:59    [W:0.096 / U:0.432 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site