lkml.org 
[lkml]   [2017]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()
From
Date
>> Add a jump target so that a bit of exception handling can be better reused
>> at the end of this function.
>
> I'm not sure this is that big of a win.

Such a view is appropriate because I proposed just another small adjustment
for this source code place.


> I mean you aren't really making the code any smaller

Would anybody like to check corresponding effects in more detail
after a specific function call was replaced by a goto statement?


> and it's not making it any easier to read really.

Is the code readability still good enough there?

Regards,
Markus

\
 
 \ /
  Last update: 2017-10-28 20:16    [W:0.298 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site